Browse Source

Refine library linkage

Viktor Kopp 6 years ago
parent
commit
b8b66b0dfd
3 changed files with 3 additions and 3 deletions
  1. 1 1
      src/grpc/CMakeLists.txt
  2. 1 1
      src/protobuf/CMakeLists.txt
  3. 1 1
      tests/CMakeLists.txt

+ 1 - 1
src/grpc/CMakeLists.txt

@@ -27,7 +27,7 @@ file(GLOB HEADERS asyncreply.h
 
 add_library(${GRPC_SUPPORT_LIBRARY_TARGET} ${SOURCES})
 set_target_properties(${GRPC_SUPPORT_LIBRARY_TARGET} PROPERTIES PUBLIC_HEADER "${HEADERS}")
-target_link_libraries(${GRPC_SUPPORT_LIBRARY_TARGET} qtprotobufsupport Qt5::Core Qt5::Network)
+target_link_libraries(${GRPC_SUPPORT_LIBRARY_TARGET} PRIVATE qtprotobufsupport PUBLIC Qt5::Network)
 
 install(TARGETS ${GRPC_SUPPORT_LIBRARY_TARGET}
     ARCHIVE DESTINATION lib

+ 1 - 1
src/protobuf/CMakeLists.txt

@@ -29,7 +29,7 @@ file(GLOB HEADERS universallistmodelbase.h
 
 add_library(${SUPPORT_LIBRARY_TARGET} ${SOURCES})
 set_target_properties(${SUPPORT_LIBRARY_TARGET} PROPERTIES PUBLIC_HEADER "${HEADERS}")
-target_link_libraries(${SUPPORT_LIBRARY_TARGET} Qt5::Core)
+target_link_libraries(${SUPPORT_LIBRARY_TARGET} PUBLIC Qt5::Core)
 
 install(TARGETS ${SUPPORT_LIBRARY_TARGET}
     ARCHIVE DESTINATION lib

+ 1 - 1
tests/CMakeLists.txt

@@ -55,6 +55,6 @@ add_executable(${testtarget} ${SOURCES} ${MOC_SOURCES} ${GENERATED_SOURCES} ${PR
 if(WIN32)
     target_link_libraries(${testtarget} "${GTEST_BOTH_LIBRARIES}/gmock_main.lib" "${GTEST_BOTH_LIBRARIES}/gmock.lib" qtprotobufsupport qtgrpc Qt5::Core)
 elseif(UNIX)
-    target_link_libraries(${testtarget} gtest qtprotobufsupport qtgrpc Qt5::Core)
+    target_link_libraries(${testtarget} gtest qtgrpc)
 endif()
 add_dependencies(${testtarget} ${testgeneration})